Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] todo improvements #173

Open
7 of 12 tasks
FabienPean-Virtonomy opened this issue Dec 2, 2022 · 6 comments
Open
7 of 12 tasks

[CI] todo improvements #173

FabienPean-Virtonomy opened this issue Dec 2, 2022 · 6 comments

Comments

@FabienPean-Virtonomy
Copy link
Collaborator

FabienPean-Virtonomy commented Dec 2, 2022

@Xiangyu-Hu
Copy link
Owner

Fabien, I have tried install the new master after your pull request.
When making, it show many times "BOOST_HEADER_DEPRECATED", do you have the same issue?
Thanks.

@Xiangyu-Hu
Copy link
Owner

Hi Fabien,

is the building in CI parallelized?
It seems that this is at least not explicit.

Xiangyu

@Xiangyu-Hu
Copy link
Owner

Xiangyu-Hu commented Dec 4, 2022

Some tests are two step test, that is, the first step for generating particles, the second for running the simulation.
In the new pull request these test are separated to two individual tests .
Generally, it is OK. However, as the particle generation is also not exact reproducible.
One may face a situation that the particle generation pass but the simulation not.
When the CI rerun failed, it will rerun simulation with previous generated particles.
In this case, this test may have no way to pass, as it uses the same particle generation which may be the reason for no pass.
Therefore, we need the combine the particle generation and simulation into a single test so that both steps are sampled at the same time.

In windows, the combined test can also be done by script.

@FabienPean-Virtonomy
Copy link
Collaborator Author

is the building in CI parallelized? It seems that this is at least not explicit.

Ninja build system does it in parallel by default.

Some tests are two step test, that is, the first step for generating particles, the second for running the simulation. In the new pull request these test are separated to two individual tests . Generally, it is OK. However, as the particle generation is also not exact reproducible. One may face a situation that the particle generation pass but the simulation not. When the CI rerun failed, it will rerun simulation with previous generated particles. In this case, this test may have no way to pass, as it uses the same particle generation which may be the reason for no pass. Therefore, we need the combine the particle generation and simulation into a single test so that both steps are sampled at the same time.

In windows, the combined test can also be done by script.

If those tests are meant to be run together, then they shouldn't be split in the first place. The source file should be doing both, then we can remove having 2 add_test by a single one.

Fabien, I have tried install the new master after your pull request. When making, it show many times "BOOST_HEADER_DEPRECATED", do you have the same issue? Thanks.

I didn't face it, did you start from a fresh environment? Please make a new issue with the complete log if it is a blocking issue

@Xiangyu-Hu
Copy link
Owner

is the building in CI parallelized? It seems that this is at least not explicit.

Ninja build system does it in parallel by default.

Some tests are two step test, that is, the first step for generating particles, the second for running the simulation. In the new pull request these test are separated to two individual tests . Generally, it is OK. However, as the particle generation is also not exact reproducible. One may face a situation that the particle generation pass but the simulation not. When the CI rerun failed, it will rerun simulation with previous generated particles. In this case, this test may have no way to pass, as it uses the same particle generation which may be the reason for no pass. Therefore, we need the combine the particle generation and simulation into a single test so that both steps are sampled at the same time.
In windows, the combined test can also be done by script.

If those tests are meant to be run together, then they shouldn't be split in the first place. The source file should be doing both, then we can remove having 2 add_test by a single one.

Fabien, the situation is, in practice these two parts are not always together. it is together only in the test.

Fabien, I have tried install the new master after your pull request. When making, it show many times "BOOST_HEADER_DEPRECATED", do you have the same issue? Thanks.

I didn't face it, did you start from a fresh environment? Please make a new issue with the complete log if it is a blocking issue

@FabienPean-Virtonomy
Copy link
Collaborator Author

FabienPean-Virtonomy commented Dec 5, 2022

The test is already the same executable with 2 add_test having different program options. It simply means having the test executable running by default (i.e. without program options) generation+timeloop. If a test is meant to test the reload of particles, then we need a dedicated one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants