Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Newtonsoft.Json package to version 12.0.2 #481

Open
grochocki opened this issue Apr 3, 2024 · 3 comments
Open

Update Newtonsoft.Json package to version 12.0.2 #481

grochocki opened this issue Apr 3, 2024 · 3 comments
Assignees

Comments

@grochocki
Copy link
Contributor

After publishing final feature update supporting VS2017 (#480), we will be unblocked form updating Newtonsoft.Json to version 12.0.2. More information here: Using Newtonsoft.Json in a Visual Studio extension.

@hansmbakker
Copy link

Question out of interest: why is XamlStyler sticking with NewtonSoft.JSON now that System.Text.JSON is available?

@mrlacey
Copy link
Contributor

mrlacey commented Apr 3, 2024

Question out of interest: why is XamlStyler sticking with NewtonSoft.JSON now that System.Text.JSON is available?

Visual Studio uses Newtonsoft.Json internally and ships with a version. Having extensions ship with a different version of Json.NET can cause hard to debug issues.
Obviously, XamlStyler works with more than just VS, but using different serialization libraries in different versions of the tool would introduce new complexities.

Why not remove Json.NET entirely? I assume it comes down to not wanting to create work with no immediate benefit (other than supporting installation on older VS versions).

@hansmbakker
Copy link

Why not remove Json.NET entirely

@mrlacey this was what I meant in #481 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants