Added ShowMessageBoxOnError option #391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution! Sorry for the delay in taking action on this PR but adding a setting to suppress error dialogs is not the approach we'd like to take here. Open to overhauling how we handle errors, but it would need to involve writing to output and/or integrating with errors/warnings pane as proposed in #271. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #387 Add option to hide "Error in StylerPackage" popup message
Created a new setting called
ShowMessageBoxOnErrorinStylerOptionsandIStylerOptions. This setting then is used inStylerPackage.Formattingwhenever theShowMessageBoxfunction is called.If
ShowMessageBoxOnError = false, the message box will not be shown.Checklist: