Duplicate selection list entries for waypoints with non-unique names

[frank-vanderhulst]

XCSoar versions having and not having the problem

7.40, but I have noticed it on earlier versions. I don't know what version it started on.

System information

Both Android & Windows

Steps to reproduce the behavior

Nav
WaypointList
In the Name field type KAI and click OK

Expected behavior

Each waypoint will appear once in the list.

Actual behavior

Some waypoints appear twice, as per the screenshot attached. There are 2 VRPs named "Kaituna Br", and each appears twice.

Do you have any idea what may have caused this?

I suspect that it's related to having two waypoints with the same name. Unfortunately, the NZ official list of VRPs at https://www.aip.net.nz/assets/AIP/Air-Navigation-Register/1-Permanent-Airspace/1_06_NZANR_Part_71_Visual_Reporting_Points_VRP.pdf contains a duplicate "Kaituna Bridge". In addition there is a VRP named "Feilding" and an airfield named "Feilding".

Do you have an idea how to solve the issue?

I guess that somehow duplicated entries are each processed twice.

As a workaround, I have manually edited the waypoints.cup file so that the Kaituna Bridge and Feilding waypoint names are unique, and the problem is no longer visible.

As an experiment, I generated a waypoints.cup file with 2 of each of the "Kaituna Bridge" waypoints and loaded it into XCSoar. This resulted in 8 entries being shown for "Kaituna Bridge" in the selection list.

waypoints.zip

[MaxKellermann]

I don't know what version it started on.

Find out, and then bisect the faulty git commit.