Code Reviewer Group #1121
Replies: 4 comments
-
I would like as far there is no time pressure. |
Beta Was this translation helpful? Give feedback.
-
I like the pre-commit idea, let robots work at first place. |
Beta Was this translation helpful? Give feedback.
-
Thix to those volunteering. I have added a codeowners file here: As described here: https://github.blog/2017-07-06-introducing-code-owners/ |
Beta Was this translation helpful? Give feedback.
-
So the first PR with the code reviewers group is up. |
Beta Was this translation helpful? Give feedback.
-
Hi,
I'd like to create a Code Reviewer group here on Github, that is added to PRs by default.
The idea is to the get code reviewed by people that know what the standards are, before @MaxKellermann needs to have a look at it.
I'd also like to add https://pre-commit.org as an additional check on PRs so that at least some basic code syle is upkept.
https://xcsoar.readthedocs.io/en/latest/policy.html#code-style
Any volunteers?
Beta Was this translation helpful? Give feedback.
All reactions