Standardize List View feature name to use title case capitalization. #61535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +70 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
alexstine
reviewed
May 10, 2024
| @@ -416,13 +416,13 @@ export default function LatestPostsEdit( { attributes, setAttributes } ) { | |||
| const layoutControls = [ | |||
| { | |||
| icon: list, | |||
| title: __( 'List view' ), | |||
| title: _x( 'List view', 'Latest posts block display setting' ), | |||
There was a problem hiding this comment.
This should be uppercase?
|
@alexstine yes those are still lowercase because it's not about the 'List VIew', as in: the tool to show and navigate the block hierarchy. Instead, those are display options of some blocks. For example, in the Latest Posts block you will find in the block toolbar two buttons to set the layout of the latest posts to 'List view' or 'Grid view' (sic...). Samein the RSS block and in the Post Template block that is part of the Query Loop block. I'd agree usint the same name 'List view' for completely different features is less than ideal and potentially confusing for users. I will create a separate issue to propose to consider unambigous names. |
SergeyBiryukov
approved these changes
May 14, 2024
|
@afercia Looks like one order CSS was missed in this PR. The linting test is broken on trunk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61531
What?
The 'List View' feature name uses inconsistent casing throughout the user interface.
Also, sometimes it is called 'block list view' and sometimes just 'list view'.
Why?
Conventionally, WordPress uses title case capitalization for feature names.
The name of a user-facing feature should be consistent.
How?
_x()translation function.Testing Instructions
Open the block list view.toOpen the List View..Testing Instructions for Keyboard
Screenshots or screencast