Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the List View term always use title case capitalization #61531

Closed
afercia opened this issue May 9, 2024 · 1 comment · Fixed by #61535
Closed

Make the List View term always use title case capitalization #61531

afercia opened this issue May 9, 2024 · 1 comment · Fixed by #61535
Assignees
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented May 9, 2024

Description

Traditionally, all WordPress feature names use title case capitalization. For example:

  • It's 'Media Library' and not 'Media library'.
  • It's 'Site Language' and not 'Site language'.
  • It's 'Site Icon' and not 'Site icon'.
  • It's Admin Color Scheme and not Admin color scheme.

And so on, for dozens of features. While this convention may not be 100% accurately used throughout the user interface, it would be great to make an effort to keep the convention for all WordPress features.

Specifically to the List VIew feature, capitalization is largely inconsistent in the UI. A few visual examples in the following screenshots:

Screenshot 2024-05-09 at 15 53 58

Also, in a few cases it is called 'Block list view'. I'd tend to think that, for consistency, it should always be called 'List View'.

Occurrences found so far to be checked:

packages/block-editor/src/components/block-navigation/dropdown.js:
  37: 			label={ __( 'List view' ) }
  72: 						{ __( 'List view' ) }

packages/block-editor/src/components/inspector-controls-tabs/utils.js:
  25: 	title: __( 'List View' ),

packages/block-library/src/latest-posts/edit.js:
  419: 			title: __( 'List view' ),

packages/block-library/src/post-template/edit.js:
  249: 			title: __( 'List view' ),

packages/block-library/src/rss/edit.js:
  102: 			title: __( 'List view' ),

packages/edit-site/src/components/editor/index.js:
  167: 		? __( 'List View' )

packages/edit-widgets/src/components/header/document-tools/index.js:
  110: 						label={ __( 'List View' ) }

packages/edit-widgets/src/components/keyboard-shortcut-help-modal/index.js:
  139: 				title={ __( 'List View shortcuts' ) }

packages/edit-widgets/src/components/layout/interface.js:
  86: 		? __( 'List View' )

packages/edit-widgets/src/components/secondary-sidebar/list-view-sidebar.js:
  52: 				<strong>{ __( 'List View' ) }</strong>

packages/editor/src/components/commands/index.js:
  124: 			? __( 'Close List View' )
  125: 			: __( 'Open List View' ),
  131: 				isListViewOpen ? __( 'List View off.' ) : __( 'List View on.' ),

packages/editor/src/components/global-keyboard-shortcuts/register-shortcuts.js:
  75: 			description: __( 'Open the block list view.' ),

packages/editor/src/components/keyboard-shortcut-help-modal/index.js:
  153: 				title={ __( 'List View shortcuts' ) }

packages/editor/src/components/preferences-modal/index.js:
  75: 								label={ __( 'Always open list view' ) }

Step-by-step reproduction instructions

  • Run a regular expression search through the codebase. Something like this should work: _n*\( '.*list view.
  • Observe the casing inconsistencies.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Feature] List View Menu item in the top toolbar to select blocks from a list of links. labels May 9, 2024
@afercia
Copy link
Contributor Author

afercia commented May 9, 2024

Note: the Latest Posts block, Post template block, RSS block and possibly others use the terminology 'List view' for their own display settings. These should not be changed. Ideally, they should use a different terminology to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant