Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command Palette: remove results for items non admin users don't have access to #61528

Open
bacoords opened this issue May 9, 2024 · 1 comment
Open

Command Palette: remove results for items non admin users don't have access to #61528

bacoords opened this issue May 9, 2024 · 1 comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Package] Commands /packages/commands [Type] Bug An existing feature does not function as intended

Comments

@bacoords
Copy link
Contributor

bacoords commented May 9, 2024

Description

Editor-level users are exposed to the command palette and can see search results for pages, templates, and template parts that they don't actually have access to edit

Related #61444
Related #61419

Step-by-step reproduction instructions

  1. Log in as an editor
  2. Enter a page to edit
  3. Type CMD+K to open the Command Palette
  4. Search for a page, template, or template part
  5. Select one and be sent to the "Sorry, you are not allowed to access this page." message

Screenshots, screen recording, code snippet

No response

Environment info

  • WordPress 6.5.3
  • Gutenberg 18.3.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@bacoords bacoords added the [Type] Bug An existing feature does not function as intended label May 9, 2024
@skorasaurus skorasaurus added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Package] Commands /packages/commands labels May 9, 2024
@annezazu annezazu changed the title Individual pages, individual templates, and individual template parts were exposed to non-admin users via the command palette Command Palette: remove results for items non admin users don't have access to May 14, 2024
@annezazu
Copy link
Contributor

Retitled this a bit to more accurate sum up what I think needs to happen, unless I'm getting something wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Package] Commands /packages/commands [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skorasaurus @bacoords @annezazu