Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should pass to DFP node by non-const IData::pointer&&? #290

Open
brettviren opened this issue Apr 1, 2024 · 0 comments
Open

Should pass to DFP node by non-const IData::pointer&&? #290

brettviren opened this issue Apr 1, 2024 · 0 comments

Comments

@brettviren
Copy link
Member

Our DFP nodes that have scalar input get it via a const IData::pointer&.

The problem with that is there is no way for the DFP body to set the shared pointer to nullptr and thus (if lucky) trigger an early free of memory.

Simply changing to IData::pointer is not sufficient as the node caller (the graph execution engine) will also be holding it.

So I think to give the opportunity for an "eager free" of some data we should pass by an lvalue IData::pointer&&.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brettviren