Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent handling of nominal drift speed in config #266

Open
brettviren opened this issue Dec 14, 2023 · 0 comments
Open

Inconsistent handling of nominal drift speed in config #266

brettviren opened this issue Dec 14, 2023 · 0 comments

Comments

@brettviren
Copy link
Member

The nominal drift speed as multiple avenues to be set which easily leads to inconsistency.

The main issue is that it may be set in the Jsonnet config and in the field response file (fr.speed). The latter typically "bakes" in a value when the field response file is transformed from whatever data came from the external field calculator (garfield, pochoir).

  • Drifter parameter drift_speed set from Jsonnet.
  • DepoTransform parameter drift_speed set from Jsonnet.
  • OmnibusSigProc uses fr.speed.
  • DepoFluxSplat uses fr.speed but allows overriding with drift_speed set from Jsonnet

There are others (in both WCT and larwirecell).

I think the best way to bring these into consistency is to adopt the approach of DepoFluxSplat (default from fr.speed but allow override).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant