Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different iface and ws_face.ident in AnodePlane.cxx for SBND #250

Open
HaiwangYu opened this issue Oct 7, 2023 · 0 comments
Open

Different iface and ws_face.ident in AnodePlane.cxx for SBND #250

HaiwangYu opened this issue Oct 7, 2023 · 0 comments
Assignees

Comments

@HaiwangYu
Copy link
Member

HaiwangYu commented Oct 7, 2023

@weihythu and @ebelchio12 found these two lines are incompatible:
https://github.com/WireCell/wire-cell-toolkit/blob/master/gen/src/AnodePlane.cxx#L175 (should use ws_face.ident)
https://github.com/WireCell/wire-cell-toolkit/blob/master/img/src/GridTiling.cxx#L95

First one is wrong when iface != ws_face.ident, which is the SBND APA1 case (iface=0, ws_face.ident=1).

Also this seems to be wrong for SBND APA1
https://github.com/WireCell/wire-cell-toolkit/blob/master/gen/src/AnodePlane.cxx#L294
acoording to convention here:
https://github.com/WireCell/wire-cell-toolkit/blob/master/iface/inc/WireCellIface/IAnodeFace.h#L35-L38
While simple search suggests this which() is actually not used:
Screenshot 2023-10-06 at 9 31 48 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants