We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iface
ws_face.ident
AnodePlane.cxx
@weihythu and @ebelchio12 found these two lines are incompatible: https://github.com/WireCell/wire-cell-toolkit/blob/master/gen/src/AnodePlane.cxx#L175 (should use ws_face.ident) https://github.com/WireCell/wire-cell-toolkit/blob/master/img/src/GridTiling.cxx#L95
First one is wrong when iface != ws_face.ident, which is the SBND APA1 case (iface=0, ws_face.ident=1).
iface=0
ws_face.ident=1
Also this seems to be wrong for SBND APA1 https://github.com/WireCell/wire-cell-toolkit/blob/master/gen/src/AnodePlane.cxx#L294 acoording to convention here: https://github.com/WireCell/wire-cell-toolkit/blob/master/iface/inc/WireCellIface/IAnodeFace.h#L35-L38 While simple search suggests this which() is actually not used:
which()
The text was updated successfully, but these errors were encountered:
brettviren
weihythu
No branches or pull requests
@weihythu and @ebelchio12 found these two lines are incompatible:
https://github.com/WireCell/wire-cell-toolkit/blob/master/gen/src/AnodePlane.cxx#L175 (should use
ws_face.ident
)https://github.com/WireCell/wire-cell-toolkit/blob/master/img/src/GridTiling.cxx#L95
First one is wrong when
iface
!=ws_face.ident
, which is the SBND APA1 case (iface=0
,ws_face.ident=1
).Also this seems to be wrong for SBND APA1
https://github.com/WireCell/wire-cell-toolkit/blob/master/gen/src/AnodePlane.cxx#L294
acoording to convention here:
https://github.com/WireCell/wire-cell-toolkit/blob/master/iface/inc/WireCellIface/IAnodeFace.h#L35-L38
While simple search suggests this
which()
is actually not used:The text was updated successfully, but these errors were encountered: