Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FrameFanin trace tagging doesn't merge #243

Open
HaiwangYu opened this issue Sep 14, 2023 · 0 comments
Open

FrameFanin trace tagging doesn't merge #243

HaiwangYu opened this issue Sep 14, 2023 · 0 comments

Comments

@HaiwangYu
Copy link
Member

The FrameFanin trace tagging seems to overwrite other than merge.

We noticed this when trying to merge dnnsp[u,v,w] into dnnsp here:
https://github.com/WireCell/wire-cell-toolkit/blob/master/cfg/layers/low/dnnroi.jsonnet#L97

This is related to the code below:
https://github.com/WireCell/wire-cell-toolkit/blob/master/gen/src/FrameFanin.cxx#L169
https://github.com/WireCell/wire-cell-toolkit/blob/master/aux/inc/WireCellAux/SimpleFrame.h#L47

A graph containing this section:
wct-sim-fans.pdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HaiwangYu