Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlobCluster may not properly handle case when two blobs shadow each other in more than one view #219

Open
brettviren opened this issue May 1, 2023 · 1 comment
Assignees

Comments

@brettviren
Copy link
Member

@lastgeorge found the use of setS for edge type in the blob-shadow graph may lead to a problem as it only allows one unique b-b edge for a single view. But, it is possible to have b-b shadows in more than one view.

This line is the hot spot to start looking at this issue:

https://github.com/WireCell/wire-cell-toolkit/blob/master/aux/src/BlobShadow.cxx#L98

@brettviren
Copy link
Member Author

Status update

I believe this is now understood as being due to using setS for edge container.

https://github.com/WireCell/wire-cell-toolkit/blob/master/aux/inc/WireCellAux/BlobShadow.h#L67

@HaiwangYu is working on this in particular replacing setS with multisetS.

A relevant function for accessing edges is boost::edge_range()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants