Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscodium new window not being rendered #276

Closed
Iss-in opened this issue Feb 24, 2024 · 14 comments
Closed

vscodium new window not being rendered #276

Iss-in opened this issue Feb 24, 2024 · 14 comments
Labels
bug Something isn't working

Comments

@Iss-in
Copy link

Iss-in commented Feb 24, 2024

For the last year or so, vscode was crashing on sway/wayland if run in wayland mode, The latest version 1.86 solves that, but it also introduced a new bug, which is making a 2nd window of vscode unable to render.

microsoft/vscode#204597

This was fixed by sway commit swaywm/sway@07b0598 and wlroots commit https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/54e1fefd2e29cb00dff7c02801913d793ceab7d6

can we please add the sway fix here

@Iss-in Iss-in added the bug Something isn't working label Feb 24, 2024
@notpeelz
Copy link

I applied the sway patch you linked against the current release of swayfx but the issue still occurs.
The wlroots commit you linked doesn't do anything either.

hashworks (from the vscode issue) is saying he couldn't reproduce the issue when testing with the latest sway/wlroots changes, and not that these specific commits fixed the issue.

@Iss-in
Copy link
Author

Iss-in commented Feb 24, 2024

weird, i will look more into this to single out the commit, latest sway/wlroots indeed fixed the issue. i thought hashworks info was credible

@hashworks
Copy link

i thought hashworks info was credible

I never said that it was those specific commits. As notpeelz said, they just were the lastest commits.

@Iss-in
Copy link
Author

Iss-in commented Feb 27, 2024

sorry for the bad info earlier, seems like latest sway release ( 1.9.1 ) has fixed the issue
hopefully we can see a rebase soon

@WillPower3309
Copy link
Owner

Hey @Iss-in , not sure if you're using swayfx-git, but the rebase is complete. Please let me know if you do and if it fixes the issue :)

@Iss-in
Copy link
Author

Iss-in commented Apr 16, 2024

thanks, will take a look, it seems that scenefx doesnt have an aur package yet, and neither as a dependency in swayfx-git aur package.
what version of wlroots is needed to build scenefx ?

@ErikReider
Copy link
Collaborator

thanks, will take a look, it seems that scenefx doesnt have an aur package yet, and neither as a dependency in swayfx-git aur package. what version of wlroots is needed to build scenefx ?

It's currently not building, waiting for #290. wlrfx/packages#1 is needed for the AUR packages to be uploaded / updated.

You can build it right now though if you build swayfx with scenefx and wlroots 0.17 as subprojects :)

@Iss-in
Copy link
Author

Iss-in commented Apr 16, 2024

thanks, i tried, and sway seems to be crashing when i move mouse or launch some app ( firefox )
http://0x0.st/X-5u.txt

@ErikReider
Copy link
Collaborator

The new aur packages are now up and running! :)

@Iss-in
Copy link
Author

Iss-in commented Apr 19, 2024

thanks, seems to be working fine, getting some weird behaviour with borders tho

swayfx_bad_borders.mp4
# Swayfx settings 
corner_radius 6
shadows enable
shadow_color #000000ff
shadow_blur_radius 6
shadows_on_csd on
# exec_always sway_theme -r
smart_corner_radius disable

blur enable
blur_radius 6
blur_passes 6
blur_xray enable
scratchpad_minimize disable

@WillPower3309
Copy link
Owner

thanks, seems to be working fine, getting some weird behaviour with borders tho

swayfx_bad_borders.mp4
# Swayfx settings 
corner_radius 6
shadows enable
shadow_color #000000ff
shadow_blur_radius 6
shadows_on_csd on
# exec_always sway_theme -r
smart_corner_radius disable

blur enable
blur_radius 6
blur_passes 6
blur_xray enable
scratchpad_minimize disable

Hmm this is alarming! Mind opening a new issue for this? :) I can take a look at it shortly

@Iss-in
Copy link
Author

Iss-in commented Apr 20, 2024

weirdly its also reproducible in upstream release version, happens only when i resize by mouse, but not with keyboard shortcuts

will file issue there

@WillPower3309
Copy link
Owner

weirdly its also reproducible in upstream release version, happens only when i resize by mouse, but not with keyboard shortcuts

will file issue there

Thanks! Feel free to link to it here if you do

@WillPower3309
Copy link
Owner

Link to upstream issue: swaywm/sway#8125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants