Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base class #509

Closed
TanyaStere42 opened this issue Apr 30, 2024 · 1 comment · Fixed by #564
Closed

Base class #509

TanyaStere42 opened this issue Apr 30, 2024 · 1 comment · Fixed by #564
Assignees
Labels
enhancement new or improvements on existing features
Milestone

Comments

@TanyaStere42
Copy link
Member

TanyaStere42 commented Apr 30, 2024

Feature description and context

To simplify the integration of OpenSearch, we want to eliminate the potential for a great deal of redundant code functions and references across our "main" classes. To do this, we'll start by taking functionality that is common across classes and creating a base class which these will inherit from.

Feature sign-off requirements

  • Encounter.java, Occurrence.java, and MarkedIndividual.java behavior, methods, etc. unchanged.
  • "fundamental" methods on above work from base class - probably abstracts that rely on above classes to return values -- including but not limited to:
    • getId() (String)
    • getVersion() (long) - each class above might have slightly different value this will be computed from, for example modified property (a date/time) on Encounter
  • Comment all methods that should get replaced with this base class with ## DEPRECATED #509 - Base class

Architectural Design Notes

  • will not change underlying column names in DB (for id)
@TanyaStere42 TanyaStere42 added enhancement new or improvements on existing features question open investigation to define scope of issue labels Apr 30, 2024
@TanyaStere42 TanyaStere42 added this to the 10.3.0 milestone Apr 30, 2024
@TanyaStere42 TanyaStere42 removed the question open investigation to define scope of issue label May 1, 2024
@TanyaStere42 TanyaStere42 changed the title Base class - DRAFT Base class May 1, 2024
@NNattoji NNattoji self-assigned this May 6, 2024
NNattoji pushed a commit to NNattoji/Wildbook that referenced this issue May 7, 2024
@NNattoji
Copy link
Contributor

NNattoji commented May 7, 2024

The base class has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new or improvements on existing features
Projects
None yet
2 participants