Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swallowed exceptions #530

Open
robertvazan opened this issue Feb 3, 2021 · 1 comment
Open

Swallowed exceptions #530

robertvazan opened this issue Feb 3, 2021 · 1 comment

Comments

@robertvazan
Copy link
Collaborator

I notice that swallowing exceptions (catching without rethrowing or wrapping) is a widespread practice in WDTK. This can sometimes result in invalid values being propagated to application or even to API calls. Can I assume that all cases of exception swallowing are bugs and fix them?
@wetneb
Copy link
Member

wetneb commented Feb 3, 2021

I think #526 is a clear improvement and I am sure there are tons of other places where we could do the same. Hard to say if it is true "everywhere", of course there is a judgment call to make…

@robertvazan robertvazan mentioned this issue Feb 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wetneb @robertvazan