Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 500-link limit for loading training slides from wiki #5588

Open
ragesoss opened this issue Jan 18, 2024 · 2 comments
Open

Fix 500-link limit for loading training slides from wiki #5588

ragesoss opened this issue Jan 18, 2024 · 2 comments

Comments

@ragesoss
Copy link
Member

There might be more than 500 training slides linked from https://meta.wikimedia.org/wiki/Training_modules/dashboard/slides

When trying to load training content from the wiki, WikiTrainingLoader does a page link query that does not implement 'continue', so only 500 links are loaded. I think this means that the oldest of the links on the page are the ones that get left out, so the oldest training modules cannot be updated. We discovered that this module errors when you attempt to reload it: https://outreachdashboard.wmflabs.org/training/learning-and-evaluation/using-the-dashboard

If the 500-link limit is the cause as I expect, implementing 'continue' should let us load that module. (Search the codebase for examples of other queries that handle 'continue'.)

@fillingtothemomo
Copy link
Contributor

@ragesoss I have implemented the continue , however I am not sure how to test it locally as I can not navigate to the learning and navigation module on my localhost.

@ragesoss
Copy link
Member Author

@fillingtothemomo to test it locally, you need to first configure your dev environment to use the wiki as the source of training content... I think maybe just setting wiki_education: false in application.yml will do that, as the three config entries for which pages to look for content should already be present.

Then you can attempt to load a single module using the same relative URL as on the production site: /reload_trainings?module=using-the-dashboard. I would expect that to fail in the current version, and work when the continue is implemented.

thekavikumar added a commit to thekavikumar/WikiEduDashboard that referenced this issue Jan 26, 2024
thekavikumar added a commit to thekavikumar/WikiEduDashboard that referenced this issue Jan 26, 2024
thekavikumar added a commit to thekavikumar/WikiEduDashboard that referenced this issue Jan 26, 2024
thekavikumar added a commit to thekavikumar/WikiEduDashboard that referenced this issue Jan 26, 2024
thekavikumar added a commit to thekavikumar/WikiEduDashboard that referenced this issue Jan 26, 2024
thekavikumar added a commit to thekavikumar/WikiEduDashboard that referenced this issue Jan 26, 2024
thekavikumar added a commit to thekavikumar/WikiEduDashboard that referenced this issue Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants