Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AbortSignal #566

Open
miketaylr opened this issue Nov 15, 2021 · 2 comments
Open

Fix AbortSignal #566

miketaylr opened this issue Nov 15, 2021 · 2 comments

Comments

@miketaylr
Copy link
Contributor

In c7c0901, I attempted to unbreak AbortSignal but didn't do a great job (oops).

Anne gave me some private feedback:

misses an equal sign at the end
Also, it seems the spec still uses AbortError unconditionally, the other change that's needed is to use signal's abort reason instead

I'll try to send in a PR today/tomorrow.
@reillyeon
Copy link
Contributor

Please fix the missing equals sign, but I don't think we want to use the abort reason unless there's a way to encapsulate it in an AbortError. Using the abort reason will mean that the Promises reject with "undefined" by default which is a rather confusing developer experience.

@miketaylr
Copy link
Contributor Author

Please fix the missing equals sign

SGTM.

@miketaylr miketaylr mentioned this issue Nov 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miketaylr @reillyeon