Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error types #42

Open
abrown opened this issue Aug 8, 2023 · 0 comments
Open

Fix the error types #42

abrown opened this issue Aug 8, 2023 · 0 comments

Comments

@abrown
Copy link
Collaborator

abrown commented Aug 8, 2023

As highlighted in #38, the error type currently returned by wasi-nn calls is limited in several ways:

  • all possible errors are included in one large enum: this should change to have separate error types for separate calls (i.e., what can go wrong for load is different than what can go wrong for compute); this may only be possible to do in WIT (?)
  • the set of errors should be audited: some errors, e.g., busy, may never be returned by any implementation so we should remove them based on current implementation experience
  • the errors are not descriptive enough: some errors, e.g., invalid-argument or model-too-large, would benefit from additional information to give the user some clue of what is going on; some of this could be improved by documentation, but being able to attach some extra data to an error might be helpful (is this possible in WIT?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant