-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions about WIT transition #24
Comments
No, I don't think so. When I switched this repository over to WIT in #17, I kept the API the same, so unless I unwittingly made a mistake, there should be no change for users. With #17 now complete, it seems like a good time to migrate existing implementations to the WIT-based tooling (e.g., in Wasmtime, in the wasi-nn bindings repository). Are you interested in helping out with that? (@radu-matei, we had talked previously about migrating the tract implementation into Wasmtime--what do you think about that now?) |
Moving the Tract implementation into Wasmtime is still a really good idea! |
wit version of get-output returns the
yes.
|
Oh, sorry, I will fix that.
You mean using wasi-nn from C code that you compile to |
In porting the WITX definition to WIT, I inadvertently changed the return type of `get-output`. @yamt identified this issue in WebAssembly#24--thank you! This change fixes the return type to the original type, `tensor-data`. (In the future, it may be interesting to return more information about the tensor, but that can be a separate issue).
In porting the WITX definition to WIT, I inadvertently changed the return type of `get-output`. @yamt identified this issue in #24--thank you! This change fixes the return type to the original type, `tensor-data`. (In the future, it may be interesting to return more information about the tensor, but that can be a separate issue).
i meant to implement wasi-nn api for C-based engines. (eg WAMR) |
when you say the API is kept, which level are you referring? |
any update regarding this? |
Looking up at the previous comments, I don't think I knew how to respond to this (and still am not clear). Let me take a stab at explaining how I see the wasi-nn world right now:
Hope that helps! |
my understanding is
am i right?
The text was updated successfully, but these errors were encountered: