Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how poll_list handles errors #48

Open
sunfishcode opened this issue Sep 29, 2023 · 3 comments
Open

Document how poll_list handles errors #48

sunfishcode opened this issue Sep 29, 2023 · 3 comments

Comments

@sunfishcode
Copy link
Member

The poll_list function itself doesn't have a return value so it's infallible. We should document how it behaves when passed invalid file descriptors.

@pchickey
Copy link

File descriptors being passed to poll_list are a thing of the past. It should be impossible to create an error because all Pollable resources are always valid to poll on, right?

@sunfishcode
Copy link
Member Author

Yes, that's right. So we should document what happens if you're using bindings like C and you're using a handle after it's been dropped.

@pchickey
Copy link

Easy enough - it will trap, just like every other case of passing an invalid resource. Agreed we can put it in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants