Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.py doesn't build tests in subdirectories #1687

Open
foolip opened this issue Oct 6, 2023 · 5 comments
Open

build.py doesn't build tests in subdirectories #1687

foolip opened this issue Oct 6, 2023 · 5 comments

Comments

@foolip
Copy link
Contributor

foolip commented Oct 6, 2023

The tests in https://github.com/WebAssembly/gc/tree/main/test/core/gc aren't build by the build.py, which only looks for *.wast files in test/core/:

https://github.com/WebAssembly/gc/blob/ec57b2a506a7e220a1cdb980adc7fdcca8b31d05/test/build.py#L70

Are these tests not being run yet, or should they be moved to the parent directory when they are complete?

@foolip
Copy link
Contributor Author

foolip commented Oct 6, 2023

This can be worked around by updating WAST_TESTS_DIR. Looking for tests recursively and generating a directory tree should be straightforward, if that is the desired behavior.

foolip referenced this issue in foolip/wpt Oct 6, 2023
Building these required hacking up the build.py script:
https://github.com/WebAssembly/gc/issues/450
@rossberg
Copy link
Member

rossberg commented Oct 6, 2023

That seems to be an oversight. It should probably have been changed in the same way as test/run.py back when SIMD tests where written or merged. I don't know who owns or uses this script.

@eqrion, @Ms2ger, @gahaas, you seem to have touched it last. Any ideas?

[Transferring issue to upstream repo.]

@rossberg rossberg transferred this issue from WebAssembly/gc Oct 6, 2023
@rossberg
Copy link
Member

rossberg commented Oct 6, 2023

That seems to be an oversight. It should probably have been changed in the same way as test/run.py back when SIMD tests where written or merged. I don't know who owns or uses this script.

@eqrion, @Ms2ger, @gahaas, you seem to have touched it last. Any ideas?

@eqrion
Copy link
Contributor

eqrion commented Oct 6, 2023

I think I touched it just to tweak error reporting. We don't use this script anymore though and have a custom way we run the spec tests in SM.

@gahaas
Copy link
Collaborator

gahaas commented Oct 10, 2023

We are also not using this script in V8. The script should be easy to fix, though, and I think there is value in having this script. I put it on my TODO list to fix it eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants