Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Switch to 'Furo' theme for core docs #1583

Closed
wants to merge 1 commit into from

Conversation

Web3NL
Copy link

@Web3NL Web3NL commented Jan 25, 2023

Closes #1573

Problem

Current 'Alabaster' theme does not support mobile and dark mode

Proposed solution

Use 'Furo' theme.
No particular technical reason for this specific theme, apart from esthetics

Todo

  • Since I'm not very familiar with Sphinx, I might have missed something. Needs checking.
  • Testing required

Building

HTML builds with same command on WSL2 setup: make html

Preview

https://eeqt3-riaaa-aaaal-qbsva-cai.ic0.app/

Screenshots

Desktop light
Index-of-Types-WebAssembly-2-0-Draft-2023-01-25-

Desktop dark
Values-WebAssembly-2-0-Draft-2023-01-25-

Mobile
Index-of-Types-WebAssembly-2-0-Draft-2023-01-25- (1)

@Web3NL Web3NL changed the title New theme proposal: Switch to 'Furo' theme [theme] Switch to 'Furo' theme Jan 25, 2023
@Web3NL Web3NL changed the title [theme] Switch to 'Furo' theme [docs] Switch to 'Furo' theme for core docs Jan 25, 2023
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like that this adapts to dark settings. But if we need to change themes to achieve that, please pick one that preserves serif fonts. This is relevant for consistency and readability, especially where embedded elements of Wasm syntax use sans-serif already and hence would no longer be distinguishable.

'searchbox.html',
]
}
# html_theme_options = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all the options disabled?

@rossberg
Copy link
Member

rossberg commented Apr 2, 2024

This has been stale for more than a year, closing.

@rossberg rossberg closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: missing mobile friendly theme with darkmode
2 participants