Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger for unit characteristics should support specs in Arena #4683

Open
JasonAsmk opened this issue Nov 1, 2023 · 2 comments
Open

Trigger for unit characteristics should support specs in Arena #4683

JasonAsmk opened this issue Nov 1, 2023 · 2 comments
Labels
🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.

Comments

@JasonAsmk
Copy link

Is your feature request related to a problem? Please describe.
I was trying to make a weakaura to show the enemy healer's castbar, so I tried:

  • show castbar in trigger 1
    AND
  • enemy unit in arena is a healer spec

But there's no way to filter for specs in Player Info -> Unit characteristics -> Arena

Describe the solution you'd like
While getting the spec is awkward due to it needing to inspect, it should be possible for arena instances because we have GetArenaOpponentSpec
as well as we could add a filter for role (tank/healer/dps) provided we have the spec above with
GetSpecializationRoleByID

Additional context
Here's the ingame picture of the relevant UI
Screenshot_2023-10-30_224015

I would consider making a PR for this if you accept contributions and passes triage. Looks good for a first issue.

@JasonAsmk JasonAsmk added the 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature. label Nov 1, 2023
@InfusOnWoW
Copy link
Contributor

A PR would be welcome, the trigger's definition is in Prototypes.lua.

@Knbi
Copy link

Knbi commented Nov 5, 2023

I would consider making a PR for this if you accept contributions and passes triage. Looks good for a first issue.

I haven't seen your FR before I made mine. If you're considering contributing/making it yourself, could you implement a spec check for a specific arena unit? See my suggestion: #4691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants