Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.18] Mystical Agriculture integration failing #1919

Open
Chaos02 opened this issue Aug 14, 2022 · 2 comments · May be fixed by #2013
Open

[1.18] Mystical Agriculture integration failing #1919

Chaos02 opened this issue Aug 14, 2022 · 2 comments · May be fixed by #2013
Labels
1.18.2 bug compatibility

Comments

@Chaos02
Copy link

Chaos02 commented Aug 14, 2022

Issue Description:

Am Modpack author. Log says Mystical agriculture integration fails.

[Worker-Main-5/ERROR] [bloodmagic/]: MysticalAgriculture integration cancelled: unable to find a class: com.blakebr0.mysticalagriculture.api.crop.ICrop
  • BloodMagic: 1.18.2-3.2.5-40
  • Minecraft: 1.18.2
  • Forge: forge-40.1.73
@WayofTime
Copy link
Owner

Thanks, will look at the changes to their methods later.

@andrewsf
Copy link

andrewsf commented Sep 8, 2022 •
edited

I noticed that "1.18 and older is NO LONGER SUPPORTED" but then breaking API changes were made in the 1.18 branch..

This MysticalAgriculture commit b77e79cb138e9b8461c33b9489b3539a36aeb516 removed the interface ICrop.

Removing an interface is a little bit crappy to do in an "api" package. But it was marked:

// TODO: 1.17: remove
@Deprecated

BloodMagic/src/main/java/wayoftime/bloodmagic/ritual/harvest/HarvestHandlerPlantable.java

Line 175 in 69b6270

Class<?> mysticalCrop = Class.forName("com.blakebr0.mysticalagriculture.api.crop.ICrop");

Now you just use the Crop class directly. And I don't know if it matters here but getCrop returns a net.minecraft.world.level.block.CropBlock, not a net.minecraft.block.CropsBlock (class renamed from 1.16 -> 1.18).

andrewsf referenced this issue in BlakeBr0/MysticalAgriculture Sep 8, 2022
@BlakeBr0
Remove ICrop, IMobSoulType, IAugment and other misc port progress
b77e79c
@BrodyWills BrodyWills mentioned this issue Jan 30, 2023
Closed
@stellanera98 stellanera98 linked a pull request Jan 9, 2024 that will close this issue
Open
@TehNut TehNut mentioned this issue Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.18.2 bug compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix mystical agriculture integration for harvest ritual stellanera98/BloodMagic
3 participants
@andrewsf @WayofTime @Chaos02