Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test framework #25

Open
rmccue opened this issue Jul 3, 2017 · 2 comments
Open

Add unit test framework #25

rmccue opened this issue Jul 3, 2017 · 2 comments
Labels

Comments

@rmccue
Copy link
Member

rmccue commented Jul 3, 2017

We need to make sure this plugin is thoroughly tested. Step 1 is adding the unit test framework.

@rmccue rmccue added the Task label Jul 3, 2017
@tfrommen
Copy link
Contributor

tfrommen commented Jul 8, 2017

I would like to take care of this. 👋

However, what PHP version do we want/have to agree on? WordPress Core still is fine with PHP 5.2.4. The current plugin codebase requires at least PHP 5.4. And when it comes to PHPUnit, we either use the completely outdated and not even maintained version 4.8 (which is incompatible with PHP 7, by the way), or use the old stable, which requires PHP 5.6 (uh oh!) and also works with PHP 7+.

Also, to make use of WordPress-specific mocking features, I would suggest to use Brain Monkey, which I like much much better than WP_Mock.

Any comments on this?

@killua99
Copy link

I might try to add some.

Altho I'll require some help with the travis connection if we use travis. Perhaps Circle CI ? idk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants