Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bugs of submission similarities #index and #show GET API routes #350

Open
2 tasks done
sibinhho99 opened this issue Oct 2, 2023 · 0 comments 路 Fixed by #349
Open
2 tasks done

馃悰 Bugs of submission similarities #index and #show GET API routes #350

sibinhho99 opened this issue Oct 2, 2023 · 0 comments 路 Fixed by #349
Assignees
Labels
Type: Bug A problem with existing functionality

Comments

@sibinhho99
Copy link
Collaborator

Cc:

Hi

Describe the Bug

(Via API)

  • Internal server error caused by double attempt to render the view when authenticating using API key
  • Pair of flagged submission similarity can't be retrieved

To Reproduce

Steps to reproduce the behavior:

  1. Try to hit the described routes using an API client
  2. Errors shown

Expected Behavior

Tasks

  • Investigate
  • Fix

Acceptance Criteria

More Information

In this line for show route we should use id instead of submission_similarity_id
https://github.com/WING-NUS/SSID/blob/535e08aebddc0f8adab47e5db22369be34479d70/app/controllers/api/v1/submission_similarities_controller.rb#L62C19-L62C19

In this line we should use rescue block for casework with a single render instead of calling multiple renders

Environment

  • Device: [e.g. iPhone 12]
  • Browser: [e.g. chrome, safari]
  • OS: [e.g. iOS]

Screenshots

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug A problem with existing functionality
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant