Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reportResult and reportWin Functions Have Different Signatures from On Device #24

Open
kevinkiklee opened this issue Dec 1, 2023 · 2 comments
Assignees
Labels

Comments

@kevinkiklee
Copy link
Collaborator

From fledge-docs created by thegreatfatzby: privacysandbox/protected-auction-services-docs#68

Thanks for the Event Level Reporting explainer!

First thing I notice is that reportResult and reportWin have different signatures than on device. It seems like browserSignals has been removed, and the table indicates that some of the fields have moved to sellerReportingMetadata in reportResult or buyer equivalent for reportWin.

I guess a couple of questions:

  1. Why have different signatures?
  2. To the extent this is the signature, will buyerReportingId and sellerAndBuyerReportingId be in the sellerReportingMetadata or buyerReportingMetadata.
@kevinkiklee kevinkiklee added the B&A label Dec 1, 2023
@kevinkiklee
Copy link
Collaborator Author

kevinkiklee commented Dec 1, 2023

Original comment by chatterjee-priyanka: privacysandbox/protected-auction-services-docs#68 (comment)


Hey,

  1. reportResult()
    (i) The directFromSellerSignals for on-device reportResult is optional, it is not relevant for B&A.
    (ii) The reason we changed the name of the arg browserSignals to sellerReportingMetadata is because this is actually reporting metadata that is not generated by the browser in case of B&A but by the TEE based Auction server based on different parameters. The contents of browserSignals (for on-device) and sellerReportingMetadata are same.

With that, the reportResult() for B&A is aligned with on-device. If you develop reportResult() for on-device browser, it should work on B&A.

reportWin()
Similarly reportWin() for on-device and reportWin() for B&A are aligned.

(i) The directFromSellerSignals argument for on-device is optional and it is not relevant to B&A.
(ii) The reason we changed the name of the arg browserSignals to sellerReportingMetadata is because this is actually reporting metadata that is not generated by the browser in case of B&A but by the TEE based Auction server based on different parameters. The contents of browserSignals (for on-device) and sellerReportingMetadata are same.

I can confirm reportResult() and reportWin() developed for browser would work in B&A. Some adtechs have validated that.

  1. As far as I know, this was introduced recently for on-device. However, this is a work in progress on the B&A side and we plan to add the support by early October and make a minor update to the reporting explainer. We will keep you posted once it is available / open sourced.

Thanks!

@kevinkiklee
Copy link
Collaborator Author

kevinkiklee commented Dec 1, 2023

Original comment by chatterjee-priyanka: privacysandbox/protected-auction-services-docs#68 (comment)


We are looking for some feedback from adtechs on this reporting question: WICG/turtledove#821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants