Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbed Application Mode: Provide tab colour customisation #58

Open
lukewarlow opened this issue Jul 10, 2022 · 1 comment
Open

Tabbed Application Mode: Provide tab colour customisation #58

lukewarlow opened this issue Jul 10, 2022 · 1 comment

Comments

@lukewarlow
Copy link

Currently the tab_strip field doesn't allow any customisation of tab colours, and Chrome's current experimental implementation uses the body's background colour for the selected tab and the app manifests theme colour unselected tabs.

I can think of use cases where a developer might want to customise this to improve the UX.

Example 1:

The developers favicon supports dark mode browser UI, using the link media attribute, but their site doesn't support dark mode yet. Currently the white background colour would be combined with the dark mode favicon leading to no or low contrast on the selected tab.

Example 2:

The applications background colour could be the same as their theme colour which would make it hard to distinguish between the current tab and other tabs.

Ideally if a way to customise this was provided it'd support at least a choice based on color-scheme media queries but should probably also account for contrast ones.

@alancutter
Copy link
Collaborator

Re example 1: I think any half implementation of dark mode will have problems like this, the site should hold off until they have a full dark mode implementation. I would not optimise for this scenario.

Re example 2: Setting the theme colour and background colour is a valid configuration, if the ability to see the tab is hard that's on the user agent for not providing enough contrast rather than on the dev.
For reference this is what it looks like in Chrome OS's experimental implementation today:
Screenshot from 2022-07-11 12-07-28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants