Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use :disabled instead of [disabled], check for contenteditable="false"? #83

Open
tigt opened this issue Jan 4, 2018 · 1 comment
Open

Comments

@tigt
Copy link

tigt commented Jan 4, 2018

CSS has the :disabled pseudo-class, since elements that are children of <fieldset disabled> act as if they had the attribute set themselves.

That would change the _focusableElementsString to look more like input:not(:disabled).

Similarly, contenteditable="false" actually means something, because contenteditable isn't a boolean variable, just confusingly similar to one. When set to false, it's not focusable. That would probably change its selector to [contenteditable]:not([contenteditable="true" i]).

@robdodson
Copy link
Collaborator

robdodson commented Feb 10, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants