Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Line Number (Current)" Color is ignored #3091

Open
2 tasks
mpdelbuono opened this issue Jan 30, 2024 · 2 comments · May be fixed by #3097
Open
2 tasks

"Line Number (Current)" Color is ignored #3091

mpdelbuono opened this issue Jan 30, 2024 · 2 comments · May be fixed by #3097

Comments

@mpdelbuono
Copy link

Describe the bug
Visual Studio 2022 has two color parameters: "Line Number", and "Line Number (Current)". The latter of these appears to be ignored; the "Line Number" color is always used regardless of the currently selected line.

To Reproduce
Steps to reproduce the behavior:

  1. Select a different color for "Line Number" and "Line Number (Current)"
  2. Execute ":set number"
  3. Select any line
  4. Notice the current line is not in the differently selected color

Expected behavior
Color of the currently selected line should be the selected color.

Screenshots
image
image
image

Environment (please complete the following information):

  • Visual Studio version: 17.8.5 (2022 64-bit)
  • VsVim version: 2.10.0.6
  • Programming Language: C#
  • Check(Type 'x') any that are installed:
    • ReSharper
    • Visual Assist

Note:
The following is written about contributing.
https://github.com/VsVim/VsVim/blob/master/CONTRIBUTING.md

General Keyboard configuration problems are described below.
#2527

@nosami
Copy link
Collaborator

nosami commented Jan 30, 2024

I think the fix needs to go in here if you'd like to have a go at it.

@nosami
Copy link
Collaborator

nosami commented Jan 30, 2024

Worth noting that the Mac version of the addin correctly handles this

IClassificationType lineNumberClassificaiton = _classificationTypeRegistry.GetClassificationType("line number");
var font = _classificationFormatMap.GetTextProperties(lineNumberClassificaiton);
IClassificationType currentLineNumberClassification = _classificationTypeRegistry.GetClassificationType("Selected Line Number");
var currentLineNumberFont = _classificationFormatMap.GetTextProperties(currentLineNumberClassification);

I guess the fix for Windows would be pretty similar (maybe the classification type name differs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants