From 9a6574afbddae581e2113e166b1c694a983a1c5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vladimir=20Jovanovi=C4=87?= Date: Tue, 16 Jan 2018 22:09:48 +0100 Subject: [PATCH] Fixed bug where View would not show inside ScrollView. (#7) Fixed bug where View would not show inside ScrollView. --- CHANGELOG.md | 5 +++++ README.md | 2 +- lemniscate/build.gradle | 4 ++-- .../vlad1m1r/lemniscate/base/BaseCurveProgressView.kt | 11 +++++------ sample/src/main/res/layout/toolbar.xml | 2 +- 5 files changed, 14 insertions(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f6bdb3..11b17f9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ Change Log ========== +Version 1.4.2 *(2018-01-16)* +---------------------------- + +* Fixed bug where View would not show inside ScrollView. [#5](https://github.com/vlad1m1r990/Lemniscate/issues/5) + Version 1.4.1 *(2018-01-06)* ---------------------------- diff --git a/README.md b/README.md index 14ef592..0a5cc52 100644 --- a/README.md +++ b/README.md @@ -34,7 +34,7 @@ Add to your module's build.gradle: and to your app build.gradle: dependencies { - compile 'com.github.vlad1m1r990:Lemniscate:1.4.1' + compile 'com.github.vlad1m1r990:Lemniscate:1.4.2' } Usage diff --git a/lemniscate/build.gradle b/lemniscate/build.gradle index e32367b..d802c0a 100644 --- a/lemniscate/build.gradle +++ b/lemniscate/build.gradle @@ -8,8 +8,8 @@ android { defaultConfig { minSdkVersion 14 targetSdkVersion 27 - versionCode 141 - versionName "1.4.1" + versionCode 142 + versionName "1.4.2" testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner" } buildTypes { diff --git a/lemniscate/src/main/java/com/vlad1m1r/lemniscate/base/BaseCurveProgressView.kt b/lemniscate/src/main/java/com/vlad1m1r/lemniscate/base/BaseCurveProgressView.kt index e36278a..2521d23 100644 --- a/lemniscate/src/main/java/com/vlad1m1r/lemniscate/base/BaseCurveProgressView.kt +++ b/lemniscate/src/main/java/com/vlad1m1r/lemniscate/base/BaseCurveProgressView.kt @@ -180,12 +180,11 @@ abstract class BaseCurveProgressView : View, IBaseCurveProgressView{ } private fun getViewDimension(mode: Int, viewSize: Float, defaultSize: Float): Float { - return if (mode == View.MeasureSpec.EXACTLY) { - viewSize - } else if (mode == View.MeasureSpec.AT_MOST) { - Math.min(defaultSize, viewSize) - } else { - defaultSize + return when { + viewSize == 0f -> defaultSize + mode == View.MeasureSpec.EXACTLY -> viewSize + mode == View.MeasureSpec.AT_MOST -> Math.min(defaultSize, viewSize) + else -> defaultSize } } diff --git a/sample/src/main/res/layout/toolbar.xml b/sample/src/main/res/layout/toolbar.xml index ae3400e..a6f274d 100644 --- a/sample/src/main/res/layout/toolbar.xml +++ b/sample/src/main/res/layout/toolbar.xml @@ -8,4 +8,4 @@ android:minHeight="?attr/actionBarSize" android:background="?attr/colorPrimary" app:popupTheme="@style/ThemeOverlay.AppCompat.Light" - app:theme="@style/ThemeOverlay.AppCompat.Dark.ActionBar"/> \ No newline at end of file + android:theme="@style/ThemeOverlay.AppCompat.Dark.ActionBar"/> \ No newline at end of file