Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIND RESULTS pane: info enhancements #787

Open
amnonma opened this issue Apr 25, 2023 · 4 comments · Fixed by #815
Open

FIND RESULTS pane: info enhancements #787

amnonma opened this issue Apr 25, 2023 · 4 comments · Fixed by #815
Labels
enhancement New feature or request priority high High priority

Comments

@amnonma
Copy link

amnonma commented Apr 25, 2023

Currently FIND RESULTS displays line number, char offset on line, rule element number.
Enhancements:
1 - Sort results according to PASS NUMBER. G("$passnum") exists. Display pass numder.
(Maybe display orphans and inactives after the active pass matches)
2. - Display RULE NUMBER. G("$rulenum") exists.
3 - Char offset should include tab ( = 4 characters, etc)
4 - Since all are .NLP, don't display tail. G("$inputhead")
5 - Mark orphan files.
6 - Mark inactive files.
7 - Preferable ordering:
X PASS RULE ELT| LINE,CHAR
(X: O = orphan pass, I = inactive pass, etc)
example active: 12 3 4 | 56,7
example orphan: O - 3 4 | 56,7
example inactive I 12 3 4 | 56,7
(8 - Not sure that we need character offset on line)
@ddehilster

@amnonma amnonma added the enhancement New feature or request label Apr 25, 2023
@amnonma amnonma added the priority high High priority label May 22, 2023
@amnonma
Copy link
Author

amnonma commented May 22, 2023

The toughest thing for me is that Find Results does not order search results according to the passes in the analyzer sequence, and/or does not label the pass numbers. Hard to see the "progression" of things, which is a benefit of multi-pass analyzers.
@dehilsterlexis

@amnonma
Copy link
Author

amnonma commented May 22, 2023

I'm tempted to rename passes so that they progress alphabetically!
aa_tokenize
bb_lexical
cc_syntax
...

@dehilsterlexis
Copy link
Collaborator

@amnonma I have created a specialized find for the analyzer sequence that lists the files in order. It also can exclude folders. I have done nothing else as you suggested. At least that should help for a while.

@amnonma
Copy link
Author

amnonma commented May 25, 2023

Looking good, David, and extremely helpful. Thanks!
@dehilsterlexis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority high High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants