Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try changing the CORS permission of the bucket #28

Open
Mulkave opened this issue Sep 23, 2014 · 2 comments
Open

Try changing the CORS permission of the bucket #28

Mulkave opened this issue Sep 23, 2014 · 2 comments

Comments

@Mulkave
Copy link
Member

Mulkave commented Sep 23, 2014

Let's have this to be optional (default true) since it is required only for loading cross-origin assets.

@filipegar
Copy link
Contributor

I'd like to work on this issue by creating a new command line function to set the CORS configuration to the bucket. I don't think it should be a turn on/off option as we need info provided by user (domains/subdomains, http methods [that are mandatory] and allowed-headers.

Maybe add to the cdn.php config file an array with AWS CORSConfiguration structure and then allow user to choose run or not it with artisan.

any other toughts, @Mulkave @Mahmoudz ?

@Mulkave
Copy link
Member Author

Mulkave commented Jan 19, 2016

@filipegar sorry for the late reply, please go ahead! PRs are always welcome 😄

A separate command sounds good, though requiring the understanding of the CORSCobfiguration structure is a bit of a hassle, u less we provide a set of user-friendly methods to represent commonly used ones.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants