Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving config to .env #121

Open
kshitijpurwar opened this issue Aug 5, 2017 · 3 comments
Open

Moving config to .env #121

kshitijpurwar opened this issue Aug 5, 2017 · 3 comments

Comments

@kshitijpurwar
Copy link

The CDN config such as region and bucketname should be moved to .env since it constitues sensitive info as well.

@uselessscat
Copy link

You only have to put in your config the env variable, like this example:

 'region' => env('AWS_S3_REGION', 'us-west'),

@kshitijpurwar
Copy link
Author

@arie-cwhat What you say is absolutely correct but it's not included the code by default which I suppose it should be because a newbie like me could just put all the sensitive info there and get my self screwed later on.
@Mulkave

@uselessscat
Copy link

uselessscat commented Oct 6, 2017

I understand 👍 it's terrible to rewrite the whole history of git just to delete a line of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants