Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with Delete Article keyboard shortcut in Vienna 3.9.0 #1735

Open
cseppan opened this issue Jan 30, 2024 · 1 comment
Open

issue with Delete Article keyboard shortcut in Vienna 3.9.0 #1735

cseppan opened this issue Jan 30, 2024 · 1 comment
Labels

Comments

@cseppan
Copy link

cseppan commented Jan 30, 2024

Describe the bug
When focus is on the article content panel, pressing the Delete key doesn't delete the article. Instead, the contents of the article panel are replaced with whatever was previously displayed, and no changes are made to the article list. If the menu option Delete Article is chosen, the article is deleted as expected. If focus is in the article list panel, either pressing the Delete key or selecting the menu option Delete Article works as expected. I'm seeing this issue regardless of whether the feed uses Load Full HTML Articles or not.

To Reproduce
With an article selected, click on the article contents so that the article panel has focus. Press the Delete key.

Please complete the following information:

  • Vienna version: 3.9.0 :7ad9df044: (8175)
  • OS version: macOS Sonoma 14.2.1 (23C71)

Additional information:
Vienna 3.8.8 does not have this issue.

@Eitot Eitot added the bug 🐞 label Jan 30, 2024
@Eitot
Copy link
Contributor

Eitot commented Jan 30, 2024

It seems that the web view overrides the keyboard shortcuts when it is "first responder".

The keyDown(with:) method in WebKitArticleView redirects button presses to AppController ‑handleKeyDown:withFlags:. However, when the web view is first responder, the switch case for NSDeleteCharacter will return NO, since it only checks whether the article list view (MessageListView) is first responder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants