Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adjectives Added #270

Merged
merged 3 commits into from
Nov 10, 2020
Merged

New Adjectives Added #270

merged 3 commits into from
Nov 10, 2020

Conversation

Arijit-101
Copy link
Contributor

Fixes #4

@Arijit-101
Copy link
Contributor Author

It said Python Linter failed.. why is it occuring ? and does that mean that the pull request failed

Copy link
Owner

@VickiLanger VickiLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for all of these additions and fixes. For a couple of them, would you mind adding commas to the end of the lines? Without them, they'll get smashed together with the next line.

@@ -9,11 +9,14 @@
# NOTE: must fit in a tweet, so not longer than this line -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|

adjectives = [
'aback',
'abaft'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a comma to the end of this line?

'sagacious',
'stoic',
'strict',
'strong'
'strong',
'understanding'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a comma to the end of this line?

'strong'
'strong',
'understanding'
'weak'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a comma to the end of this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@VickiLanger
Copy link
Owner

It said Python Linter failed.. why is it occuring ? and does that mean that the pull request failed

Good question. The liner is a bit messed up right now. It's actually catching on some other file no one touches

@Arijit-101
Copy link
Contributor Author

The python linter failed again !

@bobsany16
Copy link
Collaborator

The python linter failed again !

Yeh, the python linter failed because when I implemented it, I could not figure out how to stop telling it to reformat the files (as it is python Black linter's job) so that's why it's failing. So far, I don't know how to fix that yet 😅

Copy link
Owner

@VickiLanger VickiLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions!


Don't forget to follow the bot on Twitter to see the hard work you put in.

@VickiLanger VickiLanger merged commit c8b483a into VickiLanger:production Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add More Adjectives!
3 participants