-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adjectives Added #270
New Adjectives Added #270
Conversation
It said Python Linter failed.. why is it occuring ? and does that mean that the pull request failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for all of these additions and fixes. For a couple of them, would you mind adding commas to the end of the lines? Without them, they'll get smashed together with the next line.
words_dir/tweet_adjectives.py
Outdated
@@ -9,11 +9,14 @@ | |||
# NOTE: must fit in a tweet, so not longer than this line -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | |||
|
|||
adjectives = [ | |||
'aback', | |||
'abaft' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding a comma to the end of this line?
words_dir/tweet_adjectives.py
Outdated
'sagacious', | ||
'stoic', | ||
'strict', | ||
'strong' | ||
'strong', | ||
'understanding' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding a comma to the end of this line?
'strong' | ||
'strong', | ||
'understanding' | ||
'weak' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding a comma to the end of this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Good question. The liner is a bit messed up right now. It's actually catching on some other file no one touches |
The python linter failed again ! |
Yeh, the python linter failed because when I implemented it, I could not figure out how to stop telling it to reformat the files (as it is python Black linter's job) so that's why it's failing. So far, I don't know how to fix that yet 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions!
Don't forget to follow the bot on Twitter to see the hard work you put in.
Fixes #4