Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

north Indian chart shows incorrect values at times #126

Open
ar-daniel opened this issue Apr 29, 2024 · 3 comments
Open

north Indian chart shows incorrect values at times #126

ar-daniel opened this issue Apr 29, 2024 · 3 comments

Comments

@ar-daniel
Copy link

description
sometimes north Indian chart shows incorrect values
the corresponding south Indian chart shows correct values

sample links to reproduce issue
some example comparison of south Indian chart and north Indian chart

https://vedastroapi.azurewebsites.net/api/Calculate/SouthIndianChart/Location/London,UnitedKingdom/Time/02:30/27/02/1932/+00:00/Ayanamsa/LAHIRI
https://vedastroapi.azurewebsites.net/api/Calculate/NorthIndianChart/Location/London,UnitedKingdom/Time/02:30/27/02/1932/+00:00/Ayanamsa/LAHIRI

https://vedastroapi.azurewebsites.net/api/Calculate/SouthIndianChart/Location/Evanston,IL,UnitedStates/Time/07:55/04/10/1923/-06:00/Ayanamsa/LAHIRI
https://vedastroapi.azurewebsites.net/api/Calculate/NorthIndianChart/Location/Evanston,IL,UnitedStates/Time/07:55/04/10/1923/-06:00/Ayanamsa/LAHIRI

other things needed in chart
the north Indian should also need to show
the zodiac sign / constellation number at a corner of each house

and the background of north Indian chart is transparent in some places
it can be seen if we download and open the svg locally in computer
it will be good to make the background of the chart fully opaque

Thanks

@sengiv
Copy link
Contributor

sengiv commented Apr 29, 2024

Thank you for reporting this 🙏
will investigate 🤔 this, will update soon....

noted on the transparency suggestion, will implement👍

@sengiv
Copy link
Contributor

sengiv commented May 3, 2024

@ar-daniel so the code for North chart lost funding mid project, hence it is half developed state.
you can take a look at the code in "Library" folder and fix it, since you're aware where the mistakes are.
I highly recommend you give it a try.
please make pull request once done 🙏

@ar-daniel
Copy link
Author

I would love to fix issue or provide improvements to code base but the code is written in C# and dotnet which I don't know
and I work on Linux, not sure how code development for dotnet happens on LInux
as in some of your code files you've used Microsoft.VisualStudio.TestTools.UnitTesting for testing and such

and more importantly I only have very little knowledge in Astrology,
like I've no knowledge of the calculations behind the positioning of planets and such.

I was able to check the correctness of chart API output as I had some reference charts to do some checking
Not sure how I can help here. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants