Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes for github copilot in product.json "extensionEnabledApiProposals" #1852

Open
TimTheBig opened this issue Apr 14, 2024 · 7 comments

Comments

@TimTheBig
Copy link

TimTheBig commented Apr 14, 2024

Fixes based on #1546 (comment).
With these fixes GitHub copilot and copilot chat work on the latest stable build.

  "extensionEnabledApiProposals": {
    "GitHub.copilot": [
      "inlineCompletionsAdditions",
      "interactive",
      "interactiveUserActions",
      "terminalDataWriteEvent",
      "chatParticipant"
    ],
    "GitHub.copilot-nightly": [
      "inlineCompletionsAdditions",
      "interactive",
      "interactiveUserActions",
      "terminalDataWriteEvent",
      "chatParticipant"
    ],
    "GitHub.copilot-chat": [
      "handleIssueUri",
      "interactive",
      "interactiveUserActions",
      "terminalDataWriteEvent",
      "terminalExecuteCommandEvent",
      "terminalSelection",
      "terminalQuickFixProvider",
      "chatProvider",
      "chatVariables",
      "chatAgents",
      "chatAgents2",
      "chatAgents2Additions",
      "defaultChatAgent",
      "readonlyMessage",
      "mappedEditsProvider",
      "aiRelatedInformation",
      "codeActionAI",
      "findTextInFiles",
      "textSearchProvider",
      "chatVariableResolver",
      "newSymbolNamesProvider",
      "aiTextSearchProvider",
      "contribSourceControlInputBoxMenu",
      "testObserver",
      "findFiles2",
      "chatParticipant",
      "createAgent",
      "scmInputBoxValueProvider"
    ],
@melroy89
Copy link

Maybe create a PR instead?

@TimTheBig
Copy link
Author

Will do, should I leave the new lines or put them on one line?

@melroy89
Copy link

melroy89 commented Apr 18, 2024

I believe they have it all on a single line.. So I would stay with that. At least the arrays are on a single line.

@daiyam
Copy link
Member

daiyam commented Apr 18, 2024

VSCodium is using the same extensionEnabledApiProposals as Visual Studio Code. I've checked.

Here the script doing it https://github.com/VSCodium/vscodium/blob/master/build/update_api.sh

Those Apis depend on the version of the editor and of the extension.
Your needs seem like an older version

@TimTheBig
Copy link
Author

TimTheBig commented Apr 18, 2024

This is the current product.json, as you can see missing quite a lot:

    "GitHub.copilot": [
      "inlineCompletionsAdditions"
    ],
    "GitHub.copilot-nightly": [
      "inlineCompletionsAdditions"
    ],
    "GitHub.copilot-chat": [
      "handleIssueUri",
      "interactive",
      "terminalDataWriteEvent",
      "terminalExecuteCommandEvent",
      "terminalSelection",
      "terminalQuickFixProvider",
      "chatParticipant",
      "chatParticipantAdditions",
      "defaultChatParticipant",
      "chatVariableResolver",
      "chatProvider",
      "mappedEditsProvider",
      "aiRelatedInformation",
      "codeActionAI",
      "findTextInFiles",
      "textSearchProvider",
      "contribSourceControlInputBoxMenu",
      "newSymbolNamesProvider",
      "findFiles2",
      "extensionsAny",
      "authLearnMore",
      "testObserver"
    ],

@daiyam
Copy link
Member

daiyam commented Apr 19, 2024

VSCodium is using the same extensionEnabledApiProposals as Visual Studio Code.

@TimTheBig
Copy link
Author

TimTheBig commented Apr 20, 2024

Is it possible that those APIs are not experimental in VSCode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants