Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update new line handling #41

Closed
Teatabler opened this issue Oct 10, 2016 · 3 comments · May be fixed by #44
Closed

Update new line handling #41

Teatabler opened this issue Oct 10, 2016 · 3 comments · May be fixed by #44

Comments

@Teatabler
Copy link

In line 560, in my opinion, Chr(10) is better than vbCrLf.

559      Case "n"
560           json_BufferAppend json_buffer, vbCrLf, json_BufferPosition, json_BufferLength
561           json_Index = json_Index + 1
@timhall
Copy link
Member

timhall commented Dec 29, 2016

Related: VBA-tools/VBA-Web#270

@timhall timhall changed the title Chr(10) is better than vbCrLf Update new line handling Dec 29, 2016
Sophist-UK added a commit to Sophist-UK/VBA-JSON that referenced this issue Jan 9, 2017
@Sophist-UK
Update new line handling
c25b458 
Addresses VBA-tools#41.

Fix as per discussion in VBA-tools/VBA-Web#270
@Sophist-UK Sophist-UK mentioned this issue Jan 9, 2017
Open
Sophist-UK added a commit to Sophist-UK/VBA-Web that referenced this issue Jan 9, 2017
@Sophist-UK
Update new line handling
b00c968 
Resolves VBA-tools#270 and VBA-tools/VBA-JSON#41.

See  VBA-tools/VBA-JSON#44 for matching fix to VBA-JSON.
@Sophist-UK Sophist-UK mentioned this issue Jan 9, 2017
Open
@omegastripes
Copy link

I converted the sample {"text":"abc\r\ndef"} to object with ParseJson, then converted it to string with ConvertToJson, returned string is { "text": "abc\r\r\ndef" }
Seems ConvertToJson duplicates \r within strings.

@timhall
Copy link
Member

timhall commented Apr 6, 2018

A little more activity on #67 closing in favor of that.

@timhall timhall closed this as completed Apr 6, 2018
@joyfullservice joyfullservice mentioned this issue Jul 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update new line handling Sophist-UK/VBA-JSON
3 participants
@timhall @omegastripes @Teatabler