New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #5253 - Update Manchester (EGCC) SMR #5254
base: main
Are you sure you want to change the base?
Conversation
ammend construction area re configure stands 69 to 74 ( folder ammended ) added new stands through 811 to 807 ( these not drawn but there when we need it ) rename E4 to E10
Forgot the change log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you mention, Changelog entry also required.
Thanks @rishab-alt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you mention, Changelog entry also required.
Thanks @rishab-alt
_data/SMR Files/EGCC/EGCC.kmz
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Urgh I didn't save all the comments I did here...
Might be worth making 83 centrelines the red colour and putting in the new folder for former stands?
This folder:
Can replace this empty one:
To keep them in numerical order, and there's no point having an empty folder.
The image overlay doesn't seem to be working for me? Not critical but thought I'd mention it.
There's a random "Untitled Path", I don't know if it's being added in this PR but if you fancy working out what it is and if it can be removed or titled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was there for me , something must have gone on , let me update it and include it with the KMZ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want me to draw the new stands onto the SMR in red along with the old one or leave the old ones in because what we are drawing no scenery is compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want me to draw the new stands onto the SMR in red along with the old one or leave the old ones in because what we are drawing no scenery is compatible?
I think drawing the same stand twice in red would be confusing, so I think the way the SMR looks per this PR is fine. Then as you suggest we can add them in once scenery updates, but the .kmz is ready with them in as you've done that here. Does that sound sensible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spot on!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: Chart overlay and random path fixed. Folder structure and 83 centreline colour still pending.
@rishab-alt Just noticed as well, the name of the 80-84 (E Remote)
folder can be changed once 83 has been moved out of it to 80-82 (E Remote)
. You have already put 84 into the removed stands folder.
Fixes #5253
Summary of changes
Amend construction area
reconfigure stands 69 - 74 (folder changed in KMZ)
added new stands 811 - 807 (these are not drawn but there when needed in the future )
rename E4 to E10
Screenshots (if necessary)