Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching on windows machines #163

Closed
mpadge opened this issue Aug 4, 2021 · 2 comments
Closed

Fix caching on windows machines #163

mpadge opened this issue Aug 4, 2021 · 2 comments
Labels
must do Critically important

Comments

@mpadge
Copy link
Member

mpadge commented Aug 4, 2021

Current checks both on GitHub and CRAN windows machines fail when the cache is switched off. They have been skipped with this line:

https://github.com/ATFutures/dodgr/blob/08c5760c1d9df6c0f0f90b8708061552b991180b/tests/testthat/test-cache.R#L65

Need to find out what is happening on Windows machines and actually fix it, because it probably means that caching is not working properly on those machines.

@mpadge mpadge added the must do Critically important label Oct 21, 2021
@mpadge
Copy link
Member Author

mpadge commented Jan 27, 2022

Current CRAN version also intermittently fails on linux machines with errors like this:

Running examples in ‘dodgr-Ex.R’ failed
The error most likely occurred in:

> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Name: dodgr_contract_graph
> ### Title: dodgr_contract_graph
> ### Aliases: dodgr_contract_graph
>
> ### ** Examples
>
> graph <- weight_streetnet (hampi)
> nrow (graph) # 5,973
[1] 6813
> graph <- dodgr_contract_graph (graph)
Error in readRDS(fname_c) : error reading from connection
Calls: dodgr_contract_graph -> readRDS
Execution halted

This could and should all be fixed by importing fs and using that to construct all file paths used for caching.

@mpadge mpadge closed this as completed in 90e6f4a Mar 4, 2022
mpadge added a commit that referenced this issue Mar 4, 2022
@mpadge
Copy link
Member Author

mpadge commented Mar 4, 2022

that didn't fix it, so re-opening. The test logs are entirely uninformative, and say that R CMD check failed because one test failed, yet test results all pass. Need to debug further on an actual windows machine.

@mpadge mpadge reopened this Mar 4, 2022
@mpadge mpadge closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
must do Critically important
Projects
None yet
Development

No branches or pull requests

1 participant