-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/Allow python 3.12 #2959
Labels
Comments
MthwRobinson
added a commit
that referenced
this issue
May 17, 2024
Draft: currently blocked by argilla not supporting 3.12 Waiting for this PR to be released: argilla-io/argilla#4837 Fixes #2959 --------- Co-authored-by: Matt Robinson <mrobinson@unstructured.io> Co-authored-by: Matt Robinson <mrobinson@unstructuredai.io>
github-merge-queue bot
pushed a commit
that referenced
this issue
May 19, 2024
### Summary Closes #2959. Updates the dependency and CI to add support for Python 3.12. The MongoDB ingest tests were disabled due to jobs like [this one](https://github.com/Unstructured-IO/unstructured/actions/runs/9133383127/job/25116767333) failing due to issues with the `bson` package. `bson` is a dependency for the AstraDB connector, but `pymongo` does not work when `bson` is installed from `pip`. This issue is documented by MongoDB [here](https://pymongo.readthedocs.io/en/stable/installation.html). Spun off #3049 to resolve this. Issue seems unrelated to Python 3.12, though unsure why this didn't surface previously. Disables the `argilla` tests because `argilla` does not yet support Python 3.12. We can add the `argilla` tests back in once the PR references below is merged. You can still use the `stage_for_argilla` function if you're on `python<3.12` and you install `argilla` yourself. - argilla-io/argilla#4837 --------- Co-authored-by: Nicolò Boschi <boschi1997@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently unstructured pins the python version to >=3.9.0,<3.12. It would be great if 3.12 would be allowed too. Seems like there were two attempts to enable it before:
But the logs from the CI/CD are gone, so I am not sure why they failed.
The text was updated successfully, but these errors were encountered: