Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logspam #4054

Open
SubJunk opened this issue Sep 1, 2023 · 4 comments
Open

Logspam #4054

SubJunk opened this issue Sep 1, 2023 · 4 comments

Comments

@SubJunk
Copy link
Member

SubJunk commented Sep 1, 2023

The JUPnP trace logging is really excessive, I know you had a fix for that a while ago @SurfaceS and I asked you to revert it, but maybe we should bring it back? It makes it hard to use the logs for other things

@SurfaceS
Copy link
Contributor

SurfaceS commented Sep 2, 2023

I think that UMS not enough use the info level (most of it is under debug), and some trace should be on the debug level.
And so, the default UMS log level should be info.
We should be able to debug from the debug level, and trace on few need if debug is not enough.

I'll have a look on it to shut up some JUPnP logging.

@SubJunk
Copy link
Member Author

SubJunk commented Sep 2, 2023

I agree we have used trace too much, a lot of it should be debug

I think the reason we didn't use info much is because some users like looking at the Logs tab which defaults to info, so we tried to keep that clean

@SurfaceS
Copy link
Contributor

SurfaceS commented Sep 7, 2023

For this, I will need to know what you want to keep from it.

@SubJunk
Copy link
Member Author

SubJunk commented Sep 11, 2023

v14 looks good for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants