Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid setuptools_scm import at runtime for deployed package #3362

Open
akrherz opened this issue Jan 17, 2024 · 0 comments
Open

Avoid setuptools_scm import at runtime for deployed package #3362

akrherz opened this issue Jan 17, 2024 · 0 comments
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Enhancement Enhancement to existing functionality
Milestone
1.7.0

Comments

@akrherz
Copy link
Contributor

akrherz commented Jan 17, 2024

What should we add?

I am the least sharp tool in the python toolbox, but I have been on a performance kick lately... I have found that importing setuptools_scm adds 100ms to runtime and 7 MB to memory consumption. Of course, removing setuptools_scm from the environment would effectively stop MetPy's import, but sometimes this may not be easy either...

Anyway, I am going to PR an idea I have in this space. Feel free to burn my PR and this issue with fire. I certainly trust @dopplershift's judgement 10x than mine in this space!

Reference

No response
@akrherz akrherz added the Type: Feature New functionality label Jan 17, 2024
@dopplershift dopplershift added Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Enhancement Enhancement to existing functionality and removed Type: Feature New functionality labels Jan 17, 2024
@akrherz akrherz mentioned this issue Jan 17, 2024
Closed
3 tasks
@dopplershift dopplershift added this to the 1.7.0 milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Enhancement Enhancement to existing functionality
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

perf: use package metadata before scm akrherz/MetPy
2 participants
@akrherz @dopplershift