Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Coq.Init.Logic #235

Open
m-lindgren opened this issue Mar 7, 2023 · 2 comments
Open

Remove dependency on Coq.Init.Logic #235

m-lindgren opened this issue Mar 7, 2023 · 2 comments

Comments

@m-lindgren
Copy link
Member

After merging #234 two files still unfortunately imports Coq.Init.Logic:

  • Initiality/Interpretation.v
  • TypeCat/General.v

It's currently unclear to me if it's easy to fix or requires a more involved patch, so I'm creating this issue both as a reminder and an invitation to anyone who feels inspired to give it a try.

Most fixes related to removing Coq.Init.Logic has been replacing trivial or auto with try apply idpath, but if you're (un?)lucky you get one of the rare cases where a rewrite is performed using eq_refl and then all bets are off.

@Skantz
Copy link
Contributor

Skantz commented Jun 24, 2023

Hi,

I tried to remove the import from the last two files: https://gist.github.com/Skantz/52047f07f044846b0af2774b981d10c7

If it looks good, I am happy to submit the PR.

@benediktahrens
Copy link
Member

@Skantz : that's great, thanks a lot! It definitely looks good.

benediktahrens added a commit that referenced this issue Jun 25, 2023
#235: Remove dependency on Coq.Init.Logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants