Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix singleton sharing between client and server in singleplayer mode #121

Open
3 tasks
Unarelith opened this issue Jun 20, 2020 · 0 comments
Open
3 tasks

Fix singleton sharing between client and server in singleplayer mode #121

Unarelith opened this issue Jun 20, 2020 · 0 comments
Labels
T:Bug

Comments

@Unarelith
Copy link
Owner

Every singleton is shared between the client and the server, this is not good

  • /stop command crashes in singleplayer mode (c1176a4)
  • Implement communication with most of them via events once the message queue is implemented, and remove their condition of singleton
  • For the others, access can be shared by parent items, or ClientData and ServerData will need to be created, giving access to most of them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Unarelith