Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confocal logic has hard-coded 'x, y, z' cartesian axes #379

Open
latchr opened this issue May 10, 2018 · 0 comments
Open

Confocal logic has hard-coded 'x, y, z' cartesian axes #379

latchr opened this issue May 10, 2018 · 0 comments

Comments

@latchr
Copy link
Member

latchr commented May 10, 2018

While reviewing Pull Request #375 a substantial conversation was started around the fact that confocal logic has 'x', 'y', 'z' axes hard-coded into its class attribute names (for example, image_x_range). It is better to continue that conversation here as an issue separate from the immediate needs of that pull request (which have been simplified into a quickfix at #378).

There are a few separate questions:

  • Should confocal logic be able to handle arbitrary axis names, or is that something for the hardware module?

  • Should confocal logic be able to handle arbitrary coordinate systems (cartesian, polar, cylindrical, spherical, hyperbolic, etc)?

  • If it should handle arbitrariness of either kind, how should this be implemented (dictionary, namedtuple, base class inherited into specific daughter classes, etc)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
omniscan
  
Old Issues
Development

No branches or pull requests

3 participants