Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: trigger updates correctly when subprop is initialized with null #667

Open
ddworak opened this issue Oct 2, 2020 · 3 comments
Open

Failing test: trigger updates correctly when subprop is initialized with null #667

ddworak opened this issue Oct 2, 2020 · 3 comments
Labels
bug
Milestone
1.0

Comments

@ddworak
Copy link
Member

ddworak commented Oct 2, 2020

2f671cf
@ddworak ddworak added the bug label Oct 2, 2020
@ddworak ddworak added this to the 1.0 milestone Oct 2, 2020
@ddworak
Copy link
Member Author

ddworak commented Oct 2, 2020

Related #664, verify FileInput.single usage

@catap
Copy link
Contributor

catap commented Oct 2, 2020

@ddworak from my point of view FileInput.single should be implemented as

  def single(selectedFile: Property[Option[File]])(inputName: String, inputModifiers: Modifier*): InputBinding[JSInput] = {
    apply(selectedFile.bitransformToSeq(_.toSeq)(_.headOption), false.toProperty)(inputName, inputModifiers)
  }

anyway, I can miss some way to use it

@ddworak
Copy link
Member Author

ddworak commented Oct 2, 2020

Sure, single should be fixed in the long run - I was just suggesting a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@catap @ddworak