Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: YAML parser to read the checklist items #60

Merged
merged 7 commits into from May 14, 2024
Merged

feat: YAML parser to read the checklist items #60

merged 7 commits into from May 14, 2024

Conversation

SoloSynth1
Copy link
Collaborator

This PR adds a YAML parser for reading the checklist into a Python object.

Example codes have also been written to illustrate how to use the newly created class to obtain the tests.

Since the codes use ruamel.yaml, the conda environment file has been updated to include this additional dependency.

Closes #55.

@SoloSynth1 SoloSynth1 self-assigned this May 11, 2024
@SoloSynth1 SoloSynth1 linked an issue May 11, 2024 that may be closed by this pull request
Write a YAML parser to read the checklist items into a Python object #55
Closed
tonyshumlh
tonyshumlh reviewed May 13, 2024
View reviewed changes
Copy link
Collaborator

@tonyshumlh tonyshumlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. It works except for missing the 'fire' package in environment.yml

@SoloSynth1
Copy link
Collaborator Author

Tested. It works except for missing the 'fire' package in environment.yml

fire is already listed as a dependency in environment.yml. Refer to comment above.

@tonyshumlh
Copy link
Collaborator

My bad. I used the old environment.
Tested. It works now.

@SoloSynth1
Copy link
Collaborator Author

Thanks @tonyshumlh, I assume this means this PR is ready to be merged?

@tonyshumlh tonyshumlh merged commit 75e7341 into main May 14, 2024
@SoloSynth1 SoloSynth1 deleted the 55-write-a-yaml-parser-to-read-the-checklist-items-into-a-python-object branch May 14, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyshumlh tonyshumlh tonyshumlh approved these changes

@JohnShiuMK JohnShiuMK Awaiting requested review from JohnShiuMK

@jinyz8888 jinyz8888 Awaiting requested review from jinyz8888

Assignees

@SoloSynth1 SoloSynth1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write a YAML parser to read the checklist items into a Python object
2 participants
@SoloSynth1 @tonyshumlh